chrome/browser/ui/cocoa/browser_window_cocoa.h - Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lint + review fixes Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/browser_window.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.h

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h

index afae1126c69696daf4ab0308850cf97e52c7899a..ea8e6281d48b26c686a04004370e8ca7e039b06c 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h

@@ -5,6 +5,8 @@

#ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_

#define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_

+#include <string>

#include "base/memory/scoped_nsobject.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/bookmarks/bookmark_model.h"

@@ -100,7 +102,8 @@ class BrowserWindowCocoa :

virtual void ShowOneClickSigninBubble(

OneClickSigninBubbleType type,

const string16& email,

- const StartSyncCallback& start_sync_callback) OVERRIDE;

+ const StartSyncCallback& start_sync_callback,

+ const std::string& error_message) OVERRIDE;

#endif

virtual bool IsDownloadShelfVisible() const OVERRIDE;

virtual DownloadShelf* GetDownloadShelf() OVERRIDE;