chrome/browser/ui/browser_window.h - Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_window.h

Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lint + review fixes Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_window.h

diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h

index b97595202fd737ebaecc165c0eb2465754ab3643..e1bc2254d01b55f0b93e5b9e69d9e308a39b342c 100644

--- a/chrome/browser/ui/browser_window.h

+++ b/chrome/browser/ui/browser_window.h

@@ -5,6 +5,8 @@

#ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_

#define CHROME_BROWSER_UI_BROWSER_WINDOW_H_

+#include <string>

#include "base/callback_forward.h"

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/ui/base_window.h"

@@ -229,8 +231,9 @@ class BrowserWindow : public BaseWindow {

virtual void ShowOneClickSigninBubble(

OneClickSigninBubbleType type,

const string16& email,

- const StartSyncCallback& start_sync_callback) = 0;

-#endif

+ const StartSyncCallback& start_sync_callback,

+ const std::string& error_message) = 0;

Roger Tawa OOO till Jul 10th 2013/04/17 17:53:25 nit: is it better to put the error_message arg bef

noms (inactive) 2013/04/17 20:32:37 Done.

+ #endif

// Whether or not the shelf view is visible.

virtual bool IsDownloadShelfVisible() const = 0;

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('J')