Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: net/tools/tld_cleanup/README

Issue 13979002: Add support for split PSL list distinctions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed chrome_frame compilation issue Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/tld_cleanup/README
diff --git a/net/tools/tld_cleanup/README b/net/tools/tld_cleanup/README
index adaac7e3a30d88bff25c8d9eda7ecc1680e9bd1d..84dffedac65291fa3f4aa4130a2eaf613857b02a 100644
--- a/net/tools/tld_cleanup/README
+++ b/net/tools/tld_cleanup/README
@@ -4,18 +4,23 @@ When updating src/net/base/registry_controlled_domains/effective_tld_names.dat:
http://goo.gl/Ji2bB
2. Remove whitespace from the ends of the lines.
+ You could possibly use something like:
+ sed -i -e "s/\s*$//g" \
+ src/net/base/registry_controlled_domains/effective_tld_names.dat
3. Add the Chromium note back in.
-4. Build tld_cleanup.exe (the "(net)" > "tld_cleanup" project)
+4. Build tld_cleanup (the "(net)" > "tld_cleanup" project)
5. Run it (no arguments needed), typically from src/build/Release or
src/build/Debug. It will re-generate
src/net/base/registry_controlled_domains/effective_tld_names.gperf.
6. Run gperf on the new effective_tld_names.gperf:
+ pushd src/net/base/registry_controlled_domains;
gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \
- effective_tld_names.gperf > effective_tld_names.cc
+ effective_tld_names.gperf > effective_tld_names.cc;
+ popd;
It will produce a new effective_tld_names.cc.
7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,

Powered by Google App Engine
This is Rietveld 408576698