net/tools/tld_cleanup/README - Issue 13979002: Add support for split PSL list distinctions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/tools/tld_cleanup/README

Issue 13979002: Add support for split PSL list distinctions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed chrome_frame compilation issue Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« net/base/registry_controlled_domains/registry_controlled_domain.cc ('K') | « net/ssl/server_bound_cert_service.cc ('k') | net/tools/tld_cleanup/tld_cleanup.cc » ('j') | net/tools/tld_cleanup/tld_cleanup_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 When updating src/net/base/registry_controlled_domains/effective_tld_names.dat:	1 When updating src/net/base/registry_controlled_domains/effective_tld_names.dat:

2	2

3 1. Obtain the new effective_tld_names.dat, probably by downloading	3 1. Obtain the new effective_tld_names.dat, probably by downloading

4 http://goo.gl/Ji2bB	4 http://goo.gl/Ji2bB

5	5

6 2. Remove whitespace from the ends of the lines.	6 2. Remove whitespace from the ends of the lines.

	7 You could possibly use something like:

	8 sed -i -e "s/\s*$//g" \

	9 src/net/base/registry_controlled_domains/effective_tld_names.dat

7	10

8 3. Add the Chromium note back in.	11 3. Add the Chromium note back in.

9	12

10 4. Build tld_cleanup.exe (the "(net)" > "tld_cleanup" project)	13 4. Build tld_cleanup (the "(net)" > "tld_cleanup" project)

11	14

12 5. Run it (no arguments needed), typically from src/build/Release or	15 5. Run it (no arguments needed), typically from src/build/Release or

13 src/build/Debug. It will re-generate	16 src/build/Debug. It will re-generate

14 src/net/base/registry_controlled_domains/effective_tld_names.gperf.	17 src/net/base/registry_controlled_domains/effective_tld_names.gperf.

15	18

16 6. Run gperf on the new effective_tld_names.gperf:	19 6. Run gperf on the new effective_tld_names.gperf:

	20 pushd src/net/base/registry_controlled_domains;

17 gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \	21 gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \

18 effective_tld_names.gperf > effective_tld_names.cc	22 effective_tld_names.gperf > effective_tld_names.cc;

	23 popd;

19 It will produce a new effective_tld_names.cc.	24 It will produce a new effective_tld_names.cc.

20	25

21 7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,	26 7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,

22 and effective_tld_names.cc together.	27 and effective_tld_names.cc together.

OLD	NEW