Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139783016: Do not use assembly implementations of YUV conversions in MSan builds. (Closed)

Created:
6 years, 10 months ago by earthdok
Modified:
6 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Do not use assembly implementations of YUV conversions in MSan builds. MemorySanitizer is confused by assembly code. BUG=178409 R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248614

Patch Set 1 #

Patch Set 2 : fix test name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M media/base/simd/convert_rgb_to_yuv_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M media/base/yuv_convert.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
earthdok
please take a look
6 years, 10 months ago (2014-02-03 19:44:08 UTC) #1
DaleCurtis
Seems like a bad idea since it's not testing what we ship to most clients ...
6 years, 10 months ago (2014-02-03 19:48:04 UTC) #2
earthdok
On 2014/02/03 19:48:04, DaleCurtis wrote: > Seems like a bad idea since it's not testing ...
6 years, 10 months ago (2014-02-03 20:02:50 UTC) #3
DaleCurtis
lgtm
6 years, 10 months ago (2014-02-03 20:30:05 UTC) #4
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 10 months ago (2014-02-03 20:33:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/139783016/40001
6 years, 10 months ago (2014-02-03 20:34:31 UTC) #6
commit-bot: I haz the power
Change committed as 248614
6 years, 10 months ago (2014-02-03 23:45:01 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:45:01 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:45:03 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:45:05 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:45:07 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 23:45:08 UTC) #12
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698