Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Unified Diff: media/base/simd/convert_rgb_to_yuv_unittest.cc

Issue 139783016: Do not use assembly implementations of YUV conversions in MSan builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test name Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/yuv_convert.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/simd/convert_rgb_to_yuv_unittest.cc
diff --git a/media/base/simd/convert_rgb_to_yuv_unittest.cc b/media/base/simd/convert_rgb_to_yuv_unittest.cc
index d8f8b9caadbec257cd46e608b0e0cbd1f20ecfe2..fc887957d617ccb55f87beaa67a275ee0032d4ef 100644
--- a/media/base/simd/convert_rgb_to_yuv_unittest.cc
+++ b/media/base/simd/convert_rgb_to_yuv_unittest.cc
@@ -30,12 +30,19 @@ int ConvertRGBToV(const uint8* rgb, int size) {
} // namespace
+// Assembly code confuses MemorySanitizer. Do not run it in MSan builds.
+#if defined(MEMORY_SANITIZER)
+#define MAYBE_SideBySideRGB DISABLED_SideBySideRGB
+#else
+#define MAYBE_SideBySideRGB SideBySideRGB
+#endif
+
// A side-by-side test that verifies our ASM functions that convert RGB pixels
// to YUV pixels can output the expected results. This test converts RGB pixels
// to YUV pixels with our ASM functions (which use SSE, SSE2, SSE3, and SSSE3)
// and compare the output YUV pixels with the ones calculated with out reference
// functions implemented in C++.
-TEST(YUVConvertTest, SideBySideRGB) {
+TEST(YUVConvertTest, MAYBE_SideBySideRGB) {
// We skip this test on PCs which does not support SSE3 because this test
// needs it.
base::CPU cpu;
« no previous file with comments | « no previous file | media/base/yuv_convert.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698