Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1397793002: Hide the accessors for bad custom element upgrade (Closed)

Created:
5 years, 2 months ago by terry
Modified:
5 years, 2 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLElement.darttemplate View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
terry
Committed patchset #1 (id:1) manually as 78658b3a887378134250a8ce85f5bcc0e54614b9 (presubmit successful).
5 years, 2 months ago (2015-10-08 17:27:57 UTC) #1
Alan Knight
lgtm
5 years, 2 months ago (2015-10-08 17:30:57 UTC) #2
Jacob
5 years, 2 months ago (2015-10-08 20:42:14 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698