tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate - Issue 1397793002: Hide the accessors for bad custom element upgrade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

Issue 1397793002: Hide the accessors for bad custom element upgrade (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

index bb0374536b62b44f8081edec0b990a6c6f65310e..313a2ef61a4d0eafc28534078a0bebea49d8153c 100644

--- a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

+++ b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

@@ -402,7 +402,7 @@ $else

dartClass = _blink.Blink_Utils.constructElement(customElementClass, $this);

} catch (e) {

dartClass = HtmlElement.internalCreateHtmlElement();

- dartClass.badUpgrade();

+ dartClass._badUpgrade();

throw e;

} finally {

// Need to remember the Dart class that was created for this custom so