Issue 1397713007: Drop uncompiled implicit closure functions. Only seems to happen in a few co19 tests, so this is mo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1397713007: Drop uncompiled implicit closure functions. Only seems to happen in a few co19 tests, so this is mo… (Closed)

Created:
5 years, 2 months ago by rmacnak

Modified:
5 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Drop uncompiled implicit closure functions. Only seems to happen in a few co19 tests, so this is more to make asserts in BindStaticCalls/DedupStackmaps happy than to save space. Fix changed standalone entry. Add missing VM entry. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/b5979b6a22756d520a73ca21ad91f63818cf9af3

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
M	runtime/bin/main.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View	1	3 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

rmacnak

5 years, 2 months ago (2015-10-20 22:20:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b5979b6a22756d520a73ca21ad91f63818cf9af3 (presubmit successful).