Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: runtime/vm/precompiler.cc

Issue 1397713007: Drop uncompiled implicit closure functions. Only seems to happen in a few co19 tests, so this is mo… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: external Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index e6b60498b87cc5b2bf39cd887d1ad244a440f769..a9d90b7ab2ea81123778daeb15aa6fb83c9a180a 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -147,13 +147,19 @@ void Precompiler::AddRoots(Dart_QualifiedFunctionName embedder_entry_points[]) {
kTypedDataUint16ArrayCid,
kTypedDataUint32ArrayCid,
kTypedDataUint64ArrayCid,
-
kTypedDataInt8ArrayCid,
kTypedDataInt16ArrayCid,
kTypedDataInt32ArrayCid,
kTypedDataInt64ArrayCid,
kExternalTypedDataUint8ArrayCid,
+ kExternalTypedDataUint16ArrayCid,
+ kExternalTypedDataUint32ArrayCid,
+ kExternalTypedDataUint64ArrayCid,
+ kExternalTypedDataInt8ArrayCid,
+ kExternalTypedDataInt16ArrayCid,
+ kExternalTypedDataInt32ArrayCid,
+ kExternalTypedDataInt64ArrayCid,
kTypedDataFloat32ArrayCid,
kTypedDataFloat64ArrayCid,
@@ -223,6 +229,7 @@ void Precompiler::AddRoots(Dart_QualifiedFunctionName embedder_entry_points[]) {
{ "dart:isolate", "::", "_startMainIsolate" },
{ "dart:isolate", "_RawReceivePortImpl", "_handleMessage" },
{ "dart:isolate", "_RawReceivePortImpl", "_lookupHandler" },
+ { "dart:isolate", "_SendPortImpl", "send" },
{ "dart:vmservice", "::", "_registerIsolate" },
{ "dart:vmservice", "::", "boot" },
{ NULL, NULL, NULL } // Must be terminated with NULL entries.
@@ -680,6 +687,7 @@ void Precompiler::DropUncompiledFunctions() {
function ^= functions.At(j);
if (function.HasCode()) {
retained_functions.Add(function);
+ function.DropUncompiledImplicitClosureFunction();
} else {
dropped_function_count_++;
if (FLAG_trace_precompiler) {
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698