third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 1397713004: Don't bother layout until first navigation is done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1397713004: Don't bother layout until first navigation is done. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the check to Document::updateLayoutTree Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index a9fbdd44bd4fdca2e423dea7113601938e41478c..1a62588672cf3f3ac6a49d2b852f824f0c18c5ac 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -4681,7 +4681,7 @@ TEST_P(ParameterizedWebFrameTest, CompositedSelectionBoundsCleared)

// The frame starts with no selection.

WebFrame* frame = webViewHelper.webView()->mainFrame();

ASSERT_TRUE(frame->hasSelection());

- EXPECT_TRUE(fakeSelectionLayerTreeView.getAndResetSelectionCleared());

+ EXPECT_FALSE(fakeSelectionLayerTreeView.selection());

// The selection cleared notification should be triggered upon layout.

frame->executeCommand(WebString::fromUTF8("Unselect"));