third_party/WebKit/Source/web/tests/TextFinderTest.cpp - Issue 1397713004: Don't bother layout until first navigation is done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/TextFinderTest.cpp

Issue 1397713004: Don't bother layout until first navigation is done. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the check to Document::updateLayoutTree Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/TextFinderTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/TextFinderTest.cpp b/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

index e3e716d68154a17c953a6a5ddf46ceba47c8ca96..40e2cf366562ca80a42c05243a4a5568f91e345b 100644

--- a/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

+++ b/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

@@ -31,7 +31,10 @@ class TextFinderTest : public ::testing::Test {

protected:

TextFinderTest()

{

- m_webViewHelper.initialize();

+ // Explicitly navigate to about:blank to avoid operating on

+ // initial empty document.

+ m_webViewHelper.initializeAndLoad("about:blank");

WebLocalFrameImpl& frameImpl = *m_webViewHelper.webViewImpl()->mainFrameImpl();

frameImpl.viewImpl()->resize(WebSize(640, 480));

frameImpl.viewImpl()->updateAllLifecyclePhases();