Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 13977008: Chrome AURA/ASH on Windows 8 should not attempt to shutdown the browser if there (Closed)

Created:
7 years, 8 months ago by ananta
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Chrome AURA/ASH on Windows 8 should not attempt to shutdown the browser if there are windows open in the other side. Chrome AURA and ASH in Windows 8 share the same browser process. If the browser windows on one side are closed then we should not attempt to shutdown if there are browser windows open in the other side (desktop/ASH) BUG=232245 R=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195003

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M chrome/browser/lifetime/application_lifetime.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ananta
7 years, 8 months ago (2013-04-17 02:36:54 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/13977008/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/13977008/diff/1/chrome/browser/ui/browser.cc#newcode626 chrome/browser/ui/browser.cc:626: if (BrowserList::GetInstance(other_desktop)->empty()) should this change go into chrome/browser/lifetime/application_lifetime.cc ?
7 years, 8 months ago (2013-04-17 21:37:44 UTC) #2
ananta
https://codereview.chromium.org/13977008/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/13977008/diff/1/chrome/browser/ui/browser.cc#newcode626 chrome/browser/ui/browser.cc:626: if (BrowserList::GetInstance(other_desktop)->empty()) On 2013/04/17 21:37:44, cpu wrote: > should ...
7 years, 8 months ago (2013-04-17 22:03:06 UTC) #3
ananta
Adding ben for owners lgtm
7 years, 8 months ago (2013-04-17 23:20:16 UTC) #4
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-18 18:21:43 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-18 20:09:34 UTC) #6
ananta
7 years, 8 months ago (2013-04-18 21:12:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r195003 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698