Chrome AURA/ASH on Windows 8 should not attempt to shutdown the browser if there

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // defined(OS_WIN)
@@ skipping 598 matching lines @@
 
   // Application should shutdown on last window close if the user is explicitly
   // trying to quit, or if there is nothing keeping the browser alive (such as
   // AppController on the Mac, or BackgroundContentsService for background
   // pages).
   bool should_quit_if_last_browser =
       browser_shutdown::IsTryingToQuit() || !chrome::WillKeepAlive();
 
   if (should_quit_if_last_browser &&
       BrowserList::GetInstance(host_desktop_type_)->size() == 1) {
+#if defined(OS_WIN) && defined(USE_AURA)
+    // On Windows 8 browser windows could be open in ASH and in the desktop. We
+    // should not start the shutdown process if browser windows are open in the
+    // other environment.
+    chrome::HostDesktopType other_desktop =
+        (host_desktop_type_ == chrome::HOST_DESKTOP_TYPE_NATIVE ?
+            chrome::HOST_DESKTOP_TYPE_ASH : chrome::HOST_DESKTOP_TYPE_NATIVE);
+    if (BrowserList::GetInstance(other_desktop)->empty())

[cpu_(ooo_6.6-7.5), 2013/04/17 21:37:44]

should this change go into chrome/browser/lifetime/application_lifetime.cc ?

[ananta, 2013/04/17 22:03:06]

Done. Added a function ShouldStartShutdown in application_lifetime.cc 

+#endif
     browser_shutdown::OnShutdownStarting(browser_shutdown::WINDOW_CLOSE);
   }
 
   // Don't use GetForProfileIfExisting here, we want to force creation of the
   // session service so that user can restore what was open.
   SessionService* session_service =
       SessionServiceFactory::GetForProfile(profile());
   if (session_service)
     session_service->WindowClosing(session_id());
 
@@ skipping 1626 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }