Initial surface aggregator implementation

Initial surface aggregator implementation

BUG=334876
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247598

[jamesr, 2014-01-22 22:14:51]

I believe this patch produces aggregated frames that are structurally correct
(i.e. they have the right passes and the right quads within them), but have
incorrect properties.  I'm not setting the transform, clip properties, resource
IDs, or correct render pass IDs on the quads.  I'm also not fully validated the
incoming data or generating the hit test data.  Regardless, I think this is a
reasonable checkpoint to start from.

[jamesr, 2014-01-22 23:06:02]

https://codereview.chromium.org/139763003/diff/180001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator_test_helpers.h (right):

https://codereview.chromium.org/139763003/diff/180001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator_test_helpers.h:25: int data;  // surface_id for
type=='S', color for type=='C'
turns out this is too simple for anything useful, i'll expand this to have a
DrawQuad::Material member and static helpers to construct different quad types
with different data

[jamesr, 2014-01-24 02:43:02]

I didn't understand that render passes were organized into draw order, so both
the code and the tests were assembling things in the wrong order.  I've flipped
things around and added some deeper tests and added render pass ID remapping, so
the patch is sadly a lot bigger now but a lot closer to something correct.

[enne (OOO), 2014-01-28 01:57:44]

lgtm

This seems like a good first step.

[jamesr, 2014-01-28 01:59:45]

On 2014/01/28 01:57:44, enne wrote:
> lgtm
> 
> This seems like a good first step.

Thanks!  I've noticed I'm getting some of the shared quad state pointers wrong,
but that's easier to fix with a patch that tests for the correct behavior so
I'll leave it for a follow-up.

[commit-bot: I haz the power, 2014-01-28 02:01:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/139763003/240001

[commit-bot: I haz the power, 2014-01-28 02:01:28]

Failed to apply patch for cc/cc_tests.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/cc_tests.gyp
  Hunk #1 FAILED at 366.
  1 out of 1 hunk FAILED -- saving rejects to file cc/cc_tests.gyp.rej

Patch:       cc/cc_tests.gyp
Index: cc/cc_tests.gyp
diff --git a/cc/cc_tests.gyp b/cc/cc_tests.gyp
index
23793aa44f5e6c8af867e4dc0d39f36d14d894a6..ebf9f7522a6d9f169d835a0c255669ae1ef4115b
100644
--- a/cc/cc_tests.gyp
+++ b/cc/cc_tests.gyp
@@ -366,6 +366,9 @@
         'test/run_all_unittests.cc',
         'test/cc_test_suite.cc',
         'surfaces/surface_unittest.cc',
+        'surfaces/surface_aggregator_unittest.cc',
+        'surfaces/surface_aggregator_test_helpers.cc',
+        'surfaces/surface_aggregator_test_helpers.h',
       ],
       'include_dirs': [
         'test',

[commit-bot: I haz the power, 2014-01-28 02:51:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/139763003/270001

[commit-bot: I haz the power, 2014-01-28 03:18:03]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-28 06:02:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/139763003/270001

[commit-bot: I haz the power, 2014-01-28 18:36:21]

Retried try job too often on linux_aura for step(s) app_list_unittests,
aura_unittests, browser_tests, compositor_unittests, content_browsertests,
content_unittests, events_unittests, interactive_ui_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[jamesr, 2014-01-28 18:40:42]

https://codereview.chromium.org/139763003/diff/270001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator_unittest.cc (right):

https://codereview.chromium.org/139763003/diff/270001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator_unittest.cc:73: test::Pass passes[] = {{quads,
arraysize(quads)}};
annoying! gcc doesn't like this form of initializer lists :(

[commit-bot: I haz the power, 2014-01-28 22:13:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/139763003/290001

[commit-bot: I haz the power, 2014-01-28 22:42:18]

Retried try job too often on linux_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-28 22:46:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/139763003/290001

[commit-bot: I haz the power, 2014-01-29 01:25:41]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 01:43:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/139763003/290001

[commit-bot: I haz the power, 2014-01-29 02:34:23]

Change committed as 247598