Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1397593002: Fix analyzer warnings in dart:_vmservice (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix analyzer warnings in dart:_vmservice BUG= Committed: https://github.com/dart-lang/sdk/commit/c9334ed61f11df2d9aecc6311a5981eba0e55c01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M sdk/lib/vmservice/client.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/message.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/message_router.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/running_isolate.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/running_isolates.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/vmservice.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
TBR=rmacnak@
5 years, 2 months ago (2015-10-07 20:31:24 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as c9334ed61f11df2d9aecc6311a5981eba0e55c01 (presubmit successful).
5 years, 2 months ago (2015-10-07 20:31:34 UTC) #3
rmacnak
5 years, 2 months ago (2015-10-07 20:33:13 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698