Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: sdk/lib/vmservice/vmservice.dart

Issue 1397593002: Fix analyzer warnings in dart:_vmservice (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/lib/vmservice/running_isolates.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart._vmservice; 5 library dart._vmservice;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:isolate'; 9 import 'dart:isolate';
10 import 'dart:typed_data'; 10 import 'dart:typed_data';
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 _exit(); 144 _exit();
145 return; 145 return;
146 } 146 }
147 if (message.length == 4) { 147 if (message.length == 4) {
148 // This is a message informing us of the birth or death of an 148 // This is a message informing us of the birth or death of an
149 // isolate. 149 // isolate.
150 _controlMessageHandler(message[0], message[1], message[2], message[3]); 150 _controlMessageHandler(message[0], message[1], message[2], message[3]);
151 return; 151 return;
152 } 152 }
153 } 153 }
154 Logger.root.severe( 154 print('Internal vm-service error: ignoring illegal message: $message');
155 'Internal vm-service error: ignoring illegal message: $message');
156 } 155 }
157 156
158 void _notSupported(_) { 157 void _notSupported(_) {
159 throw new UnimplementedError('Service script loading not supported.'); 158 throw new UnimplementedError('Service script loading not supported.');
160 } 159 }
161 160
162 VMService._internal() 161 VMService._internal()
163 : eventPort = isolateLifecyclePort { 162 : eventPort = isolateLifecyclePort {
164 scriptLoadPort.handler = _notSupported; 163 scriptLoadPort.handler = _notSupported;
165 eventPort.handler = messageHandler; 164 eventPort.handler = messageHandler;
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 } 322 }
324 323
325 external void _onStart(); 324 external void _onStart();
326 325
327 external void _onExit(); 326 external void _onExit();
328 327
329 external bool _vmListenStream(String streamId); 328 external bool _vmListenStream(String streamId);
330 329
331 external void _vmCancelStream(String streamId); 330 external void _vmCancelStream(String streamId);
332 331
OLDNEW
« no previous file with comments | « sdk/lib/vmservice/running_isolates.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698