Implement the framework for a paint property hierarchy

Implement the framework for a paint property hierarchy

This patch implements the framework for generating paint property
trees in blink. Paint properties represent the transforms, clips, scroll
relationships, and effects that a LayoutObject produces, and these
properties are used to create PaintChunks which are potential
compositing triggers.

The primary document covering this approach is:
https://docs.google.com/document/d/12I3JD1-Jmnb59ZHKyntFTSsNUzQhPae8QpCECtZt5zs

This patch only adds the first paint property (for transforms) and the
plumbing needed to create and update them.

BUG=537409
Committed: https://crrev.com/0e2df426e5110e0f94766d19bd33d3a732a0c1fb
Cr-Commit-Position: refs/heads/master@{#352980}

[pdr., 2015-10-07 20:17:40]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, jbroman@chromium.org, trchen@chromium.org

[pdr., 2015-10-07 20:17:40]

Ready for review!

Per our discussion at the propz meeting today, this is a cannibalization of
https://codereview.chromium.org/1390933003 (updated per reviewer comments) which
contains just the paint properties. With this patch, Tien-Ren will be able to
emit the correct transform property tree during the UpdatePaintProperties phase.

[chrishtr, 2015-10-07 20:55:56]

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:19: class
ObjectPaintProperties {
How about getting rid of this class and using graphics/paint/PaintProperties.h?
With the semantic that a null refptr means that paint property is not set on
this object and hence is inherited.

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h
(right):

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h:22:
// TODO(pdr): Refactor this into TransformPaintPropertyNode.
Maybe just nuke these old classes and start over?

[pdr., 2015-10-07 20:58:43]

On 2015/10/07 at 20:55:56, chrishtr wrote:
>
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):
> 
>
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:19: class
ObjectPaintProperties {
> How about getting rid of this class and using
graphics/paint/PaintProperties.h? With the semantic that a null refptr means
that paint property is not set on this object and hence is inherited.

There's a subtle difference between the paint properties stored on a layout
object and the paint properties stored in a paint chunk. On layout objects, we
can have multiple properties of the same type, such as m_transform and
m_perspective here. On the paint chunk we'll only have one transform property.

Maybe just put this in a comment?

> 
>
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
> File
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h
(right):
> 
>
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
>
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h:22:
// TODO(pdr): Refactor this into TransformPaintPropertyNode.
> Maybe just nuke these old classes and start over?

I plan to do this in a followup but would like to keep this patch small. Is that
okay with you?

[chrishtr, 2015-10-07 21:02:24]

On 2015/10/07 at 20:58:43, pdr wrote:
> On 2015/10/07 at 20:55:56, chrishtr wrote:
> >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):
> > 
> >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:19: class
ObjectPaintProperties {
> > How about getting rid of this class and using
graphics/paint/PaintProperties.h? With the semantic that a null refptr means
that paint property is not set on this object and hence is inherited.
> 
> There's a subtle difference between the paint properties stored on a layout
object and the paint properties stored in a paint chunk. On layout objects, we
can have multiple properties of the same type, such as m_transform and
m_perspective here. On the paint chunk we'll only have one transform property.
> 
> Maybe just put this in a comment?
> 
> > 
> >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
> > File
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h
(right):
> > 
> >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
> >
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h:22:
// TODO(pdr): Refactor this into TransformPaintPropertyNode.
> > Maybe just nuke these old classes and start over?
> 
> I plan to do this in a followup but would like to keep this patch small. Is
that okay with you?

Sure. Then change the TODO also.

[chrishtr, 2015-10-07 21:06:34]

On 2015/10/07 at 21:02:24, chrishtr wrote:
> On 2015/10/07 at 20:58:43, pdr wrote:
> > On 2015/10/07 at 20:55:56, chrishtr wrote:
> > >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
> > > File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):
> > > 
> > >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/c...
> > > third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:19: class
ObjectPaintProperties {
> > > How about getting rid of this class and using
graphics/paint/PaintProperties.h? With the semantic that a null refptr means
that paint property is not set on this object and hence is inherited.
> > 
> > There's a subtle difference between the paint properties stored on a layout
object and the paint properties stored in a paint chunk. On layout objects, we
can have multiple properties of the same type, such as m_transform and
m_perspective here. On the paint chunk we'll only have one transform property.
> > 
> > Maybe just put this in a comment?

Ok then.

> > 
> > > 
> > >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
> > > File
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h
(right):
> > > 
> > >
https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
> > >
third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h:22:
// TODO(pdr): Refactor this into TransformPaintPropertyNode.
> > > Maybe just nuke these old classes and start over?
> > 
> > I plan to do this in a followup but would like to keep this patch small. Is
that okay with you?
> 
> Sure. Then change the TODO also.

[chrishtr, 2015-10-07 21:14:28]

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
(right):

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp:102:
PaintChunk(0, 2, rootPaintProperties()),
Make the different transforms have different parameters, to make this test more
robust.

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h
(right):

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h:15: // not
simple color changes but instead represent the hierarchy of transforms,
"not local-only paint style parameters such as color,"

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h:20: struct
PaintProperties {
PaintChunkProperties

[pdr., 2015-10-07 22:15:59]

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
(right):

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp:102:
PaintChunk(0, 2, rootPaintProperties()),
On 2015/10/07 at 21:14:28, chrishtr wrote:
> Make the different transforms have different parameters, to make this test
more robust.

Done

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h
(right):

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h:15: // not
simple color changes but instead represent the hierarchy of transforms,
On 2015/10/07 at 21:14:28, chrishtr wrote:
> "not local-only paint style parameters such as color,"

Done

https://codereview.chromium.org/1397583002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h:20: struct
PaintProperties {
On 2015/10/07 at 21:14:28, chrishtr wrote:
> PaintChunkProperties

Done

[pdr., 2015-10-07 22:17:23]

Oops, missed one test which was only noticeable after uploading and looking
silly.

[chrishtr, 2015-10-07 22:18:05]

lgtm

[pdr., 2015-10-07 22:18:37]

On 2015/10/07 at 22:17:23, pdr wrote:
> Oops, missed one test which was only noticeable after uploading and looking
silly.

And.. Fixed.

PTAL

[pdr., 2015-10-07 22:19:39]

On 2015/10/07 at 22:18:37, pdr wrote:
> On 2015/10/07 at 22:17:23, pdr wrote:
> > Oops, missed one test which was only noticeable after uploading and looking
silly.
> 
> And.. Fixed.
> 
> PTAL

Ok, prepare for blastoff. Lets go to space.

[pdr., 2015-10-07 22:19:43]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-10-07 22:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397583002/40001

[commit-bot: I haz the power, 2015-10-07 23:57:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-07 23:58:16]

Patchset 3 (id:??) landed as
https://crrev.com/0e2df426e5110e0f94766d19bd33d3a732a0c1fb
Cr-Commit-Position: refs/heads/master@{#352980}