Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1397513003: Revert of Fix PartitionAlloc randomization on 32-bit systems (Closed)

Created:
5 years, 2 months ago by Alexander Potapenko
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix PartitionAlloc randomization on 32-bit systems (patchset #8 id:190001 of https://codereview.chromium.org/1383153002/ ) Reason for revert: This CL broke TSan bots, see https://crbug.com/539863 BUG=539863 Original issue's description: > Fix PartitionAlloc randomization on 32-bit systems > > Make PartitionAlloc reduce churn on Windows system allocations, and use less aggressive randomization on 32-bit systems in general. > > BUG=538479, 394591 > TBR=jchaffraix@chromium.org > > Committed: https://crrev.com/794a0e84c6d07da73b687bda35cea145310d2c76 > Cr-Commit-Position: refs/heads/master@{#352477} TBR=jchaffraix@chromium.org,jfb@chromium.org,tsepez@chromium.org,haraken@chromium.org,jschuh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=538479, 394591 Committed: https://crrev.com/1d3a58dbd9215cdb5b052f4f43c85293c9a44dc9 Cr-Commit-Position: refs/heads/master@{#353038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -76 lines) Patch
M third_party/WebKit/Source/wtf/AddressSpaceRandomization.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/wtf/PageAllocator.cpp View 5 chunks +68 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
Created Revert of Fix PartitionAlloc randomization on 32-bit systems
5 years, 2 months ago (2015-10-08 12:07:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397513003/1
5 years, 2 months ago (2015-10-08 12:07:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 12:08:58 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d3a58dbd9215cdb5b052f4f43c85293c9a44dc9 Cr-Commit-Position: refs/heads/master@{#353038}
5 years, 2 months ago (2015-10-08 12:09:51 UTC) #4
haraken
LGTM
5 years, 2 months ago (2015-10-08 12:42:39 UTC) #5
jschuh
5 years, 2 months ago (2015-10-08 16:02:19 UTC) #6
Message was sent while issue was closed.
Retroactive lgtm

Powered by Google App Engine
This is Rietveld 408576698