Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4279)

Unified Diff: build_overrides/README.md

Issue 1397493004: Move //build/module_args/v8.gni to //build_overrides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework README to hopefully be clearer Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build_overrides/README.md
diff --git a/build_overrides/README.md b/build_overrides/README.md
new file mode 100644
index 0000000000000000000000000000000000000000..d26312c9325ddcc3126ade50802a6cf879454cb1
--- /dev/null
+++ b/build_overrides/README.md
@@ -0,0 +1,20 @@
+# Build overrides in GN
+
+This directory is used to allow different products to customize settings
+for repos that are DEPS'ed in or shared.
+
+For example: V8 could be built on its own (in a "standalone" configuration),
+and it could be built as part of Chromium. V8 might define a top-level
+target, //v8:d8 (a simple executable), that should only be built in the
+standalone configuration. To figure out whether or not it should be
+in a standalone configuration, v8 can create a file, build_overrides/v8.gni,
tfarina 2015/10/13 05:11:49 Right, I think with this example I can see how thi
kjellander_chromium 2015/10/13 07:31:35 Yeah, I'm happy for the WebRTC use case, since we
+that contains a variable, `build_standalone_d8 = true`.
+and import it (as import("//build_overrides/v8.gni") from its top-level
+BUILD.gn file.
+
+Chromium, on the other hand, might not need to build d8, and so it would
+create its own build_overrides/v8.gni file, and in it set
+`build_standalone_d8 = false`.
+
+The two files should define the same set of variables, but the values can
+vary as appropriate to the needs of the two different builds.
« build/config/BUILD.gn ('K') | « build/module_args/v8.gni ('k') | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698