Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: build/module_args/v8.gni

Issue 1397493004: Move //build/module_args/v8.gni to //build_overrides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework README to hopefully be clearer Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/module_args/v8.gni
diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni
index f18bfafc8815749b603bd08d4dcc13d931aa031d..e1e5fae2629fefe06d81df735d734343b511b056 100644
--- a/build/module_args/v8.gni
+++ b/build/module_args/v8.gni
@@ -2,19 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-if (is_android) {
- import("//build/config/android/config.gni")
-}
+# TODO(dpranke): Remove this file altogether once v8 has been updated
+# to import //build_overrides/v8.gni instead.
-# TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.
-enable_correct_v8_arch = false
-
-v8_use_external_startup_data = !(is_chromeos || is_win || is_ios)
-
-# V8 extras
-# Adding V8 extras files requires API owners review
-# Be sure to synchronize with build/common.gypi
-
-v8_extra_library_files = []
-v8_experimental_extra_library_files =
- [ "../third_party/WebKit/Source/core/streams/ByteLengthQueuingStrategy.js" ]
+import("//build_overrides/v8.gni")

Powered by Google App Engine
This is Rietveld 408576698