Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1397493002: Make assembler not include the entire compiler. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make assembler not include the entire compiler. This removes the include of compiler.h from all our assemblers, which was only needed for the SourcePosition class. R=jkummerow@chromium.org Committed: https://crrev.com/83a3fc7e7fe5575c5acf64a92a2f6388d4e0d017 Cr-Commit-Position: refs/heads/master@{#31157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-07 16:18:46 UTC) #2
Jakob Kummerow
Beautiful! LGTM.
5 years, 2 months ago (2015-10-07 16:55:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397493002/1
5 years, 2 months ago (2015-10-07 16:56:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 16:57:19 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 16:57:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83a3fc7e7fe5575c5acf64a92a2f6388d4e0d017
Cr-Commit-Position: refs/heads/master@{#31157}

Powered by Google App Engine
This is Rietveld 408576698