Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1391973002: Remove unused bailout reasons. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-sourcepos
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused bailout reasons. This removes stale strings from the bailout-reason.h file that are no longer being used and hence only eat up space in the binary. R=bmeurer@chromium.org Committed: https://crrev.com/68126b52fa8c1bf851bd3f484b5c8f038bb98478 Cr-Commit-Position: refs/heads/master@{#31161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M src/bailout-reason.h View 6 chunks +0 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
1) Run ./tools/check-unused-bailouts.sh 2) ??? 3) Profit!
5 years, 2 months ago (2015-10-07 16:38:44 UTC) #1
Benedikt Meurer
Nice. LGTM
5 years, 2 months ago (2015-10-07 17:05:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391973002/1
5 years, 2 months ago (2015-10-07 18:23:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 18:27:19 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 18:27:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68126b52fa8c1bf851bd3f484b5c8f038bb98478
Cr-Commit-Position: refs/heads/master@{#31161}

Powered by Google App Engine
This is Rietveld 408576698