Issue 1397483002: Restrict memory maps dump provider to only android and linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1397483002: Restrict memory maps dump provider to only android and linux (Closed)

Created:
5 years, 2 months ago by ssid

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@smaps_fscan

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Restrict memory maps dump provider to only android and linux The memory maps dump provider is used only in android and linux, and not yet supported in windows. So, this should be compiled only in linux and android. BUG=461788

Patch Set 1 #

Patch Set 2 : maybe this? #

Patch Set 3 : maybe this? #

Patch Set 4 : Fixing. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -28 lines)			Patch
M	base/trace_event/BUILD.gn	View		4 chunks	+5 lines, -2 lines	0 comments	Download
M	base/trace_event/process_memory_maps_dump_provider.h	View	1 2 3	2 chunks	+1 line, -5 lines	0 comments	Download
M	base/trace_event/process_memory_maps_dump_provider.cc	View	1 2 3	4 chunks	+1 line, -8 lines	0 comments	Download
M	base/trace_event/process_memory_maps_dump_provider_unittest.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	base/trace_event/trace_event.gypi	View	2	3 chunks	+12 lines, -10 lines	0 comments	Download
M	tools/gn/bootstrap/bootstrap.py	View		2 chunks	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1332943002 Patch 280001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #5 (id:80001) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages