base/trace_event/process_memory_maps_dump_provider.h - Issue 1397483002: Restrict memory maps dump provider to only android and linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_maps_dump_provider.h

Issue 1397483002: Restrict memory maps dump provider to only android and linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@smaps_fscan

Patch Set: Fixing. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/process_memory_maps_dump_provider.h

diff --git a/base/trace_event/process_memory_maps_dump_provider.h b/base/trace_event/process_memory_maps_dump_provider.h

index 74529bd1c23aefc4ce84ddedb6a55c273a58daff..f302a48dd7da182f587545e929f75ed3f91baf97 100644

--- a/base/trace_event/process_memory_maps_dump_provider.h

+++ b/base/trace_event/process_memory_maps_dump_provider.h

@@ -9,10 +9,6 @@

#include "base/memory/singleton.h"

#include "base/trace_event/memory_dump_provider.h"

-#if defined(OS_LINUX) || defined(OS_ANDROID)

-#include "base/files/scoped_file.h"

-#endif

namespace base {

namespace trace_event {

@@ -29,7 +25,7 @@ class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider {

friend struct DefaultSingletonTraits<ProcessMemoryMapsDumpProvider>;

FRIEND_TEST_ALL_PREFIXES(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps);

-#if defined(OS_LINUX) || defined(OS_ANDROID)

+#if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_NACL)

static FILE* proc_smaps_for_testing;

#endif

« no previous file with comments | « base/trace_event/BUILD.gn ('k') | base/trace_event/process_memory_maps_dump_provider.cc » ('j') | no next file with comments »