Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139743017: Don't propagate Inherit ad infinitum. (Closed)

Created:
6 years, 11 months ago by rune
Modified:
6 years, 11 months ago
Reviewers:
caseq, esprehn
CC:
blink-reviews, caseq+blink_chromium.org, sof, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, Inactive, chrishtr, ykyyip
Visibility:
Public.

Description

Don't propagate Inherit ad infinitum. In recalcStyle, when the StyleRecalcChange became Inherit it was effectively a Force causing a full subtree recalc even for the parts of the subtree that didn't need to propagate inherited properties further. For instance, setting document.body.style.color would always cause a full document recalc. This change effectively reverts https://codereview.chromium.org/119693002 which relied on Inherit being a Force for SubtreeStyleChange. R=esprehn@chromium.org BUG=336908 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165739

Patch Set 1 #

Patch Set 2 : --no-find-copies #

Total comments: 2

Patch Set 3 : Don't abuse timeline tests #

Total comments: 4

Patch Set 4 : Fixed test review issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
A LayoutTests/fast/css/recalc-inherit-001.html View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/recalc-inherit-001-expected.txt View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
rune
6 years, 11 months ago (2014-01-22 23:19:34 UTC) #1
caseq
https://codereview.chromium.org/139743017/diff/30001/LayoutTests/inspector/timeline/recalc-inherit-001.html File LayoutTests/inspector/timeline/recalc-inherit-001.html (right): https://codereview.chromium.org/139743017/diff/30001/LayoutTests/inspector/timeline/recalc-inherit-001.html#newcode13 LayoutTests/inspector/timeline/recalc-inherit-001.html:13: InspectorTest.startTimeline(function() { This looks a bit like abuse of ...
6 years, 11 months ago (2014-01-23 11:11:18 UTC) #2
rune
https://codereview.chromium.org/139743017/diff/30001/LayoutTests/inspector/timeline/recalc-inherit-001.html File LayoutTests/inspector/timeline/recalc-inherit-001.html (right): https://codereview.chromium.org/139743017/diff/30001/LayoutTests/inspector/timeline/recalc-inherit-001.html#newcode13 LayoutTests/inspector/timeline/recalc-inherit-001.html:13: InspectorTest.startTimeline(function() { On 2014/01/23 11:11:19, caseq wrote: > This ...
6 years, 11 months ago (2014-01-23 13:11:32 UTC) #3
esprehn
I added chrishtr@ and ykyyip@ since we're about to undo their optimization. I just had ...
6 years, 11 months ago (2014-01-23 18:38:01 UTC) #4
rune
On 2014/01/23 18:38:01, esprehn wrote: > I added chrishtr@ and ykyyip@ since we're about to ...
6 years, 11 months ago (2014-01-23 21:10:08 UTC) #5
rune
https://codereview.chromium.org/139743017/diff/120001/LayoutTests/fast/css/recalc-inherit-001.html File LayoutTests/fast/css/recalc-inherit-001.html (right): https://codereview.chromium.org/139743017/diff/120001/LayoutTests/fast/css/recalc-inherit-001.html#newcode4 LayoutTests/fast/css/recalc-inherit-001.html:4: <title>Elements affected by LocalStyleChange Inherit</title> On 2014/01/23 18:38:02, esprehn ...
6 years, 11 months ago (2014-01-23 21:10:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/139743017/210001
6 years, 11 months ago (2014-01-23 21:13:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=23802
6 years, 11 months ago (2014-01-24 00:43:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/139743017/210001
6 years, 11 months ago (2014-01-24 07:21:44 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=23910
6 years, 11 months ago (2014-01-24 10:15:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/139743017/210001
6 years, 11 months ago (2014-01-24 10:29:06 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 13:32:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 165739

Powered by Google App Engine
This is Rietveld 408576698