LayoutTests/inspector/timeline/recalc-inherit-001.html - Issue 139743017: Don't propagate Inherit ad infinitum.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/timeline/recalc-inherit-001.html

Issue 139743017: Don't propagate Inherit ad infinitum. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: --no-find-copies Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Elements affected by LocalStyleChange Inherit</title>

	5 <script src="../../http/tests/inspector/inspector-test.js"></script>

	6 <script src="../../http/tests/inspector/timeline-test.js"></script>

	7 <script>

	8 function setBodyColor() {

	9 document.body.style.color = "pink";

	10 document.body.offsetTop;

	11 }

	12 function test() {

	13 InspectorTest.startTimeline(function() {
	caseq 2014/01/23 11:11:19 This looks a bit like abuse of timeline tests (we This looks a bit like abuse of timeline tests (we might want to change the data we report in RecalculateStyles), could you rather use window.internals.needsLayoutCount()? rune 2014/01/23 13:11:33 I am using window.internals.updateStyleAndReturnAf Show quoted text On 2014/01/23 11:11:19, caseq wrote: > This looks a bit like abuse of timeline tests (we might want to change the data > we report in RecalculateStyles), could you rather use > window.internals.needsLayoutCount()? I am using window.internals.updateStyleAndReturnAffectedElementCount() now. It's adding an extra StyleResolver access compared to the affected element count I get from timeline. Haven't checked, but I assume it's just the nature of what it's reporting.
	14 InspectorTest.evaluateInPage("setBodyColor()");

	15 });

	16

	17 InspectorTest.waitForRecordType("RecalculateStyles", finish);

	18 function finish() {

	19 InspectorTest.printTimelineRecords("RecalculateStyles");

	20 InspectorTest.completeTest();

	21 }

	22 }

	23 </script>

	24 <style>

	25 div { color: black; }

	26 </style>

	27 </head>

	28 <body onload="runTest()">

	29 <div>

	30 <div></div>

	31 <div></div>

	32 <div></div>

	33 <div></div>

	34 <div></div>

	35 <div></div>

	36 <div></div>

	37 <div></div>

	38 <div></div>

	39 <div></div>

	40 <div></div>

	41 <div></div>

	42 <div></div>

	43 <div></div>

	44 </div>

	45 </body>

	46 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/inspector/timeline/recalc-inherit-001-expected.txt » ('j') | no next file with comments »