Source/core/dom/Element.cpp - Issue 139743005: Replace RenderFullScreen with top layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 139743005: Replace RenderFullScreen with top layer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: TestExpectations for /virtual/android/fullscreen Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index aff399f4b84719b13b22ab2811853fd989851923..778bbe93681d08f968d62d52795d0fd3c82b822e 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2793,7 +2793,8 @@ bool Element::needsPseudoElement(PseudoId pseudoId, const RenderStyle& style) co

return false;

if (!renderer() || !pseudoElementRendererIsNeeded(&style))

return false;

- if (!renderer()->canHaveGeneratedChildren())

+ /* It's safe to have a backdrop since its renderer is always a child of RenderView. */

+ if (pseudoId != BACKDROP && !renderer()->canHaveGeneratedChildren())

return false;

return true;

}

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/FullscreenElementStack.h » ('j') | no next file with comments »