Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 139743005: Replace RenderFullScreen with top layer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations for /virtual/android/fullscreen Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/FullscreenElementStack.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2775 matching lines...) Expand 10 before | Expand all | Expand 10 after
2786 } else if (change >= Inherit || needsStyleRecalc()) 2786 } else if (change >= Inherit || needsStyleRecalc())
2787 createPseudoElementIfNeeded(pseudoId); 2787 createPseudoElementIfNeeded(pseudoId);
2788 } 2788 }
2789 2789
2790 bool Element::needsPseudoElement(PseudoId pseudoId, const RenderStyle& style) co nst 2790 bool Element::needsPseudoElement(PseudoId pseudoId, const RenderStyle& style) co nst
2791 { 2791 {
2792 if (pseudoId == BACKDROP && !isInTopLayer()) 2792 if (pseudoId == BACKDROP && !isInTopLayer())
2793 return false; 2793 return false;
2794 if (!renderer() || !pseudoElementRendererIsNeeded(&style)) 2794 if (!renderer() || !pseudoElementRendererIsNeeded(&style))
2795 return false; 2795 return false;
2796 if (!renderer()->canHaveGeneratedChildren()) 2796 /* It's safe to have a backdrop since its renderer is always a child of Rend erView. */
2797 if (pseudoId != BACKDROP && !renderer()->canHaveGeneratedChildren())
2797 return false; 2798 return false;
2798 return true; 2799 return true;
2799 } 2800 }
2800 2801
2801 void Element::createPseudoElementIfNeeded(PseudoId pseudoId) 2802 void Element::createPseudoElementIfNeeded(PseudoId pseudoId)
2802 { 2803 {
2803 if (isPseudoElement()) 2804 if (isPseudoElement())
2804 return; 2805 return;
2805 2806
2806 RefPtr<PseudoElement> element = document().ensureStyleResolver().createPseud oElementIfNeeded(*this, pseudoId); 2807 RefPtr<PseudoElement> element = document().ensureStyleResolver().createPseud oElementIfNeeded(*this, pseudoId);
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
3638 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3639 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3639 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3640 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3640 if (hasTagName(optionTag) || hasTagName(optgroupTag)) 3641 if (hasTagName(optionTag) || hasTagName(optgroupTag))
3641 return false; 3642 return false;
3642 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3643 if (FullscreenElementStack::isActiveFullScreenElement(this))
3643 return false; 3644 return false;
3644 return true; 3645 return true;
3645 } 3646 }
3646 3647
3647 } // namespace WebCore 3648 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/FullscreenElementStack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698