Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1397323002: Disable bad test and don't allow registerElement of direct class in dart:html or dart:svg (Closed)

Created:
5 years, 2 months ago by terry
Modified:
5 years, 2 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable bad test and don't allow registerElement of direct class in dart:html or dart:svg TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/5c04f8a13c5965bcf910d5ed7a8bcab468eca81e

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
terry
Committed patchset #2 (id:20001) manually as 5c04f8a13c5965bcf910d5ed7a8bcab468eca81e (presubmit successful).
5 years, 2 months ago (2015-10-12 10:17:30 UTC) #1
Alan Knight
5 years, 2 months ago (2015-10-12 19:45:45 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698