Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

Issue 1397323002: Disable bad test and don't allow registerElement of direct class in dart:html or dart:svg (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dartium.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
index 2871d1c7c8dd6666c28f63f088a5f440d1399c1e..3f651f2044d146020a1983d503f2caaa8c460abe 100644
--- a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
+++ b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
@@ -358,9 +358,8 @@ $else
// Figure out which DOM class is being extended from the user's Dart class.
var classMirror = reflectClass(customElementClass);
- var isHtmlElement = classMirror.qualifiedName == #dart.dom.html.HtmlElement;
var locationUri = classMirror.location.sourceUri.toString();
- if (!isHtmlElement && (locationUri == 'dart:html' || locationUri == 'dart:svg')) {
+ if (locationUri == 'dart:html' || locationUri == 'dart:svg') {
throw new DomException.jsInterop("HierarchyRequestError: Cannot register an existing dart:html or dart:svg type.");
}
« no previous file with comments | « tests/co19/co19-dartium.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698