Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 13973017: Revert "Revert "Allow multiple tags in native clause."" (Closed)

Created:
7 years, 8 months ago by sra1
Modified:
7 years, 8 months ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Allow multiple tags in native clause."" WebKit with a 'K', not 'k' Committed: https://code.google.com/p/dart/source/detail?r=21853

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+662 lines, -679 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 6 chunks +7 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 4 chunks +0 lines, -11 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 317 chunks +317 lines, -317 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 143 chunks +143 lines, -143 lines 0 comments Download
M sdk/lib/typeddata/dart2js/typeddata_dart2js.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 27 chunks +27 lines, -27 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 27 chunks +27 lines, -27 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/core_type_check_native_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/downcast_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/field_type2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/field_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/hash_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/is_check_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/issue9182_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity2_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_arguments1_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_fields_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_avoids_hidden_name_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_2_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance1_frog_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance2_frog_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance3_frog_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance4_frog_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check1_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check3_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_with_dart_methods_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_closure_identity_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_constructor_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_equals_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_exceptions1_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_name_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_1_frog_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_2_frog_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_library_same_name_used_lib2.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_inlining_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_rename1_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_rename2_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename3_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_with_keyword_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_missing_method1_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_missing_method2_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_mixin_field_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_with_plain_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception2_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception3_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception4_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception5_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_novel_html_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_null_closure_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_null_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_property_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_to_string_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_use_native_name_in_table_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function3_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +14 lines, -6 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
sra1
7 years, 8 months ago (2013-04-22 22:57:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r21853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698