Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1397113003: relnote: Refactor stream buffer allocation out into a scoped_ptr. (Closed)

Created:
5 years, 2 months ago by ramant (doing other things)
Modified:
5 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Zhongyi Shi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Refactor stream buffer allocation out into a scoped_ptr. No functional change. This is intended to support free listing the stream buffer allocations. Merge internal change: 103088826 R=rch@chromium.org Committed: https://crrev.com/f60c32d8eab385d3ae4e1277c4f77b0c644fe9cd Cr-Commit-Position: refs/heads/master@{#353917}

Patch Set 1 #

Patch Set 2 : Used scoped_ptr and Pass instead of unique_ptr and std::move #

Patch Set 3 : Fix mac compiler error #

Patch Set 4 : Merge with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -44 lines) Patch
M net/quic/quic_packet_creator.h View 3 chunks +7 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 5 chunks +9 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 2 4 chunks +5 lines, -7 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 4 chunks +11 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 1 2 3 chunks +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
ramant (doing other things)
5 years, 2 months ago (2015-10-12 23:09:59 UTC) #1
ramant (doing other things)
On 2015/10/12 23:09:59, ramant wrote: Hi Ryan, This CL is not ready. Still testing it. ...
5 years, 2 months ago (2015-10-13 00:04:44 UTC) #3
ramant (doing other things)
Hi Ryan, Mac doesn't support std::vector<scoped_ptr> yet. Thus kept the old code in quic_protocol.[h|cc] for ...
5 years, 2 months ago (2015-10-13 18:10:03 UTC) #5
Ryan Hamilton
On 2015/10/13 18:10:03, ramant wrote: > Hi Ryan, > Mac doesn't support std::vector<scoped_ptr> yet. Thus ...
5 years, 2 months ago (2015-10-13 22:38:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397113003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397113003/60001
5 years, 2 months ago (2015-10-13 22:57:40 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-14 00:07:15 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:08:40 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f60c32d8eab385d3ae4e1277c4f77b0c644fe9cd
Cr-Commit-Position: refs/heads/master@{#353917}

Powered by Google App Engine
This is Rietveld 408576698