[runtime] Fancify KeyAccumulator

src/elements.h

Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index c238a7a2178b9b3753685ae97dac52f621e0d52a..48190cbfeaec906b9bd2498a7947131075832b1b 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -32,10 +32,12 @@ class ElementsAccessor {
   // the ElementsKind of the ElementsAccessor. If backing_store is NULL, the
   // holder->elements() is used as the backing store.
   virtual bool HasElement(Handle<JSObject> holder, uint32_t index,
-                          Handle<FixedArrayBase> backing_store) = 0;
+                          Handle<FixedArrayBase> backing_store,
+                          PropertyAttributes filter = NONE) = 0;

[Igor Sheludko, 2015/10/15 09:51:43]

Please add a comment about filter parameter. How exactly does it filter out
entries? What does NONE mean?

 
-  inline bool HasElement(Handle<JSObject> holder, uint32_t index) {
-    return HasElement(holder, index, handle(holder->elements()));
+  inline bool HasElement(Handle<JSObject> holder, uint32_t index,
+                         PropertyAttributes filter = NONE) {
+    return HasElement(holder, index, handle(holder->elements()), filter);
   }
 
   // Returns true if the backing store is compact in the given range
@@ -102,7 +104,7 @@ class ElementsAccessor {
 
   virtual void AddElementsToKeyAccumulator(Handle<JSObject> receiver,
                                            KeyAccumulator* accumulator,
-                                           KeyFilter filter) = 0;
+                                           AddKeyConversion convert) = 0;
 
   // Returns a shared ElementsAccessor for the specified ElementsKind.
   static ElementsAccessor* ForKind(ElementsKind elements_kind) {
@@ -153,13 +155,14 @@ class ElementsAccessor {
   virtual Handle<Object> Shift(Handle<JSArray> receiver,
                                Handle<FixedArrayBase> backing_store) = 0;
 
+  virtual uint32_t GetCapacity(JSObject* holder,
+                               FixedArrayBase* backing_store) = 0;
+
  protected:
   friend class LookupIterator;
 
   static ElementsAccessor* ForArray(FixedArrayBase* array);
 
-  virtual uint32_t GetCapacity(JSObject* holder,
-                               FixedArrayBase* backing_store) = 0;
 
   // Element handlers distinguish between entries and indices when they
   // manipulate elements. Entries refer to elements in terms of their location