Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397053002: Introduce DartType.unaliased to avoid use of Resolution in the backend. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce DartType.unaliased to avoid use of Resolution in the backend. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/ab5225a35315ca16e8679ac99d61c8f3c4a642d0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -143 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 24 chunks +82 lines, -86 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +4 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 7 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_order_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes: dart_types.dart elements/modelx.dart resolution/typedefs.dart
5 years, 2 months ago (2015-10-09 11:11:23 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1397053002/diff/1/pkg/compiler/lib/src/dart_types.dart File pkg/compiler/lib/src/dart_types.dart (right): https://codereview.chromium.org/1397053002/diff/1/pkg/compiler/lib/src/dart_types.dart#newcode87 pkg/compiler/lib/src/dart_types.dart:87: DartType unalias(Resolution resolution) => this; Should return void. ...
5 years, 2 months ago (2015-10-12 08:17:16 UTC) #3
Johnni Winther
https://codereview.chromium.org/1397053002/diff/1/pkg/compiler/lib/src/dart_types.dart File pkg/compiler/lib/src/dart_types.dart (right): https://codereview.chromium.org/1397053002/diff/1/pkg/compiler/lib/src/dart_types.dart#newcode87 pkg/compiler/lib/src/dart_types.dart:87: DartType unalias(Resolution resolution) => this; On 2015/10/12 08:17:16, sigurdm ...
5 years, 2 months ago (2015-10-12 09:18:12 UTC) #4
Johnni Winther
5 years, 2 months ago (2015-10-12 09:29:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ab5225a35315ca16e8679ac99d61c8f3c4a642d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698