Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: pkg/compiler/lib/src/native/behavior.dart

Issue 1397053002: Introduce DartType.unaliased to avoid use of Resolution in the backend. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/native_emitter.dart ('k') | pkg/compiler/lib/src/native/ssa.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/native/behavior.dart
diff --git a/pkg/compiler/lib/src/native/behavior.dart b/pkg/compiler/lib/src/native/behavior.dart
index c742a7d1014b418d17711ca10e29263aaa638313..7dbab30fe5e6f1e7f29b4a3b0715474e6abca661 100644
--- a/pkg/compiler/lib/src/native/behavior.dart
+++ b/pkg/compiler/lib/src/native/behavior.dart
@@ -749,7 +749,8 @@ class NativeBehavior {
/// Models the behavior of having intances of [type] escape from Dart code
/// into native code.
void _escape(DartType type, Resolution resolution) {
- type = type.unalias(resolution);
+ type.computeUnaliased(resolution);
+ type = type.unaliased;
if (type is FunctionType) {
FunctionType functionType = type;
// A function might be called from native code, passing us novel
@@ -765,7 +766,8 @@ class NativeBehavior {
/// from native code. We usually start the analysis by capturing a native
/// method that has been used.
void _capture(DartType type, Resolution resolution) {
- type = type.unalias(resolution);
+ type.computeUnaliased(resolution);
+ type = type.unaliased;
if (type is FunctionType) {
FunctionType functionType = type;
_capture(functionType.returnType, resolution);
@@ -780,7 +782,8 @@ class NativeBehavior {
static dynamic _parseType(
String typeString,
Parsing parsing,
- lookup(name), locationNodeOrElement) {
+ lookup(name),
+ locationNodeOrElement) {
DiagnosticReporter reporter = parsing.reporter;
if (typeString == '=Object') return SpecialType.JsObject;
if (typeString == 'dynamic') {
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/native_emitter.dart ('k') | pkg/compiler/lib/src/native/ssa.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698