Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397043002: Introduce BackendImpact to separate enqueueing from data. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce BackendImpact to separate enqueueing from data. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/ec41c5f1414261e33e1352ed207080d0496fe0af

Patch Set 1 #

Patch Set 2 : Remove Feature.NEW_SYMBOL #

Total comments: 10

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+826 lines, -746 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 8 chunks +7 lines, -110 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 2 4 chunks +27 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 21 chunks +166 lines, -544 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +262 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +289 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 2 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 19 chunks +25 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in: common/resolution.dart js_backend/backend.dart js_backend/backend_helpers.dart (new) js_backend/backend_impact.dart (new) dart_backend/backend.dart
5 years, 2 months ago (2015-10-09 09:44:28 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1397043002/diff/20001/pkg/compiler/lib/src/dart_backend/backend.dart File pkg/compiler/lib/src/dart_backend/backend.dart (right): https://codereview.chromium.org/1397043002/diff/20001/pkg/compiler/lib/src/dart_backend/backend.dart#newcode274 pkg/compiler/lib/src/dart_backend/backend.dart:274: /// Register dynamic access of member of [type] ...
5 years, 2 months ago (2015-10-09 10:55:38 UTC) #3
Johnni Winther
https://codereview.chromium.org/1397043002/diff/20001/pkg/compiler/lib/src/dart_backend/backend.dart File pkg/compiler/lib/src/dart_backend/backend.dart (right): https://codereview.chromium.org/1397043002/diff/20001/pkg/compiler/lib/src/dart_backend/backend.dart#newcode274 pkg/compiler/lib/src/dart_backend/backend.dart:274: /// Register dynamic access of member of [type] that ...
5 years, 2 months ago (2015-10-09 11:35:56 UTC) #4
Johnni Winther
5 years, 2 months ago (2015-10-09 13:01:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ec41c5f1414261e33e1352ed207080d0496fe0af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698