Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1397043002: Introduce BackendImpact to separate enqueueing from data. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/resolution.dart ('k') | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index 3d168d3850d868714ad0ccf634e1798151171ee9..c93308b7d4ce8523121ebf93b6392ea2b299d9d2 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -503,7 +503,7 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
ir.Primitive value = visit(node.expression);
JumpTarget target = elements.getTargetDefinition(node);
Element error =
- (compiler.backend as JavaScriptBackend).getFallThroughError();
+ (compiler.backend as JavaScriptBackend).helpers.fallThroughError;
irBuilder.buildSimpleSwitch(target, value, cases, defaultCase, error,
sourceInformationBuilder.buildGeneric(node));
}
@@ -2492,10 +2492,10 @@ class GlobalProgramInformation {
}
FunctionElement get stringifyFunction {
- return _backend.getStringInterpolationHelper();
+ return _backend.helpers.stringInterpolationHelper;
}
- FunctionElement get throwTypeErrorHelper => _backend.getThrowTypeError();
+ FunctionElement get throwTypeErrorHelper => _backend.helpers.throwTypeError;
ClassElement get nullClass => _compiler.nullClass;
@@ -2513,7 +2513,7 @@ class GlobalProgramInformation {
}
Element get closureConverter {
- return _backend.getClosureConverter();
+ return _backend.helpers.closureConverter;
}
void addNativeMethod(FunctionElement function) {
@@ -3288,7 +3288,7 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
@override
ir.Primitive buildStaticNoSuchMethod(Selector selector,
List<ir.Primitive> arguments) {
- Element thrower = backend.getThrowNoSuchMethod();
+ Element thrower = backend.helpers.throwNoSuchMethod;
ir.Primitive receiver = irBuilder.buildStringConstant('');
ir.Primitive name = irBuilder.buildStringConstant(selector.name);
ir.Primitive argumentList = irBuilder.buildListLiteral(null, arguments);
@@ -3313,7 +3313,7 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
@override
ir.Primitive buildRuntimeError(String message) {
return irBuilder.buildStaticFunctionInvocation(
- backend.getThrowRuntimeError(),
+ backend.helpers.throwRuntimeError,
new CallStructure.unnamed(1),
[irBuilder.buildStringConstant(message)]);
}
@@ -3321,7 +3321,7 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
@override
ir.Primitive buildAbstractClassInstantiationError(ClassElement element) {
return irBuilder.buildStaticFunctionInvocation(
- backend.getThrowAbstractClassInstantiationError(),
+ backend.helpers.throwAbstractClassInstantiationError,
new CallStructure.unnamed(1),
[irBuilder.buildStringConstant(element.name)]);
}
« no previous file with comments | « pkg/compiler/lib/src/common/resolution.dart ('k') | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698