chrome/browser/ui/browser_command_controller.cc - Issue 1396923003: Autofill: Replace "save credit card" infobar with a bubble (Views only).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1396923003: Autofill: Replace "save credit card" infobar with a bubble (Views only). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweak SaveCardBubbleControllerImpl::DidNavigateMainFrame logic. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/save_card_bubble_view.h ('k') | chrome/browser/ui/browser_commands.h » ('j') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index a87d2e9dd83e5c186e8b86257c000e2458f3dfa0..dedf0b7f585ec7e85b9c3b14d07aab451d7a8e55 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -556,6 +556,9 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

BasicPrint(browser_);

break;

#endif // ENABLE_BASIC_PRINTING

+ case IDC_SAVE_CREDIT_CARD_FOR_PAGE:

+ SaveCreditCard(browser_);

sky 2015/10/26 20:56:26 Shouldn't you only enable this if it actually does

bondd 2015/10/27 01:06:39 Done. I also ifdef'd SaveCreditCard() out of brows

+ break;

case IDC_TRANSLATE_PAGE:

Translate(browser_);

break;