Autofill: Replace "save credit card" infobar with a bubble (Views only).

chrome/browser/ui/browser_command_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_command_controller.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 538 matching lines @@
       break;
     case IDC_PRINT:
       Print(browser_);
       break;
 #if defined(ENABLE_BASIC_PRINTING)
     case IDC_BASIC_PRINT:
       content::RecordAction(base::UserMetricsAction("Accel_Advanced_Print"));
       BasicPrint(browser_);
       break;
 #endif  // ENABLE_BASIC_PRINTING
+    case IDC_SAVE_CREDIT_CARD_FOR_PAGE:
+      SaveCreditCard(browser_);

[sky, 2015/10/26 20:56:26]

Shouldn't you only enable this if it actually does something? For example, don't
enable on mac yet.

[bondd, 2015/10/27 01:06:39]

Done. I also ifdef'd SaveCreditCard() out of browser_commands.h and
browser_commands.cc. Please let me know if I misunderstood and you'd like me to
undo that.

In other news I found out an hour ago that "TOOLKIT_VIEWS" seems to be defined
for Mac builds too, even when Views is not enabled (???). If that's really the
case I'll change things from "#if defined (TOOLKIT_VIEWS)" to "#if
defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_WIN)" everywhere in this
CL before committing.

+      break;
     case IDC_TRANSLATE_PAGE:
       Translate(browser_);
       break;
     case IDC_MANAGE_PASSWORDS_FOR_PAGE:
       ManagePasswordsForPage(browser_);
       break;
 
     // Page encoding commands
     case IDC_ENCODING_AUTO_DETECT:
       browser_->ToggleEncodingAutoDetect();
@@ skipping 804 matching lines @@
 
 BrowserWindow* BrowserCommandController::window() {
   return browser_->window();
 }
 
 Profile* BrowserCommandController::profile() {
   return browser_->profile();
 }
 
 }  // namespace chrome