Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 1396923003: Autofill: Replace "save credit card" infobar with a bubble (Views only). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace browser tests with unit tests. Address reviewer comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index 393637191d77aac6ef469f0f09ffbaeb5cf8d03a..cacd3fe1b0c6414445c2fb5e9b726686949426c8 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -19,6 +19,7 @@
#include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
#include "chrome/browser/ui/autofill/create_card_unmask_prompt_view.h"
#include "chrome/browser/ui/autofill/credit_card_scanner_controller.h"
+#include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
@@ -153,9 +154,19 @@ void ChromeAutofillClient::OnUnmaskVerificationResult(GetRealPanResult result) {
void ChromeAutofillClient::ConfirmSaveCreditCard(
const base::Closure& save_card_callback) {
+// TODO(bondd): Implement save card bubble for OS_MACOSX.
+#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_WIN)
Evan Stade 2015/10/22 23:02:43 probably can just do TOOLKIT_VIEWS?
bondd 2015/10/23 03:32:34 Done.
+ // Do lazy initialization of SaveCardBubbleControllerImpl.
+ autofill::SaveCardBubbleControllerImpl::CreateForWebContents(web_contents());
+ autofill::SaveCardBubbleControllerImpl* controller =
+ autofill::SaveCardBubbleControllerImpl::FromWebContents(web_contents());
+ controller->SetCallback(save_card_callback);
+ controller->ShowBubble();
+#else
AutofillCCInfoBarDelegate::Create(
InfoBarService::FromWebContents(web_contents()), this,
save_card_callback);
+#endif
}
bool ChromeAutofillClient::HasCreditCardScanFeature() {

Powered by Google App Engine
This is Rietveld 408576698