Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/browser/ui/autofill/save_card_bubble_controller_impl.h

Issue 1396923003: Autofill: Replace "save credit card" infobar with a bubble (Views only). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace browser tests with unit tests. Address reviewer comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..d9f556a14cfe986bdbf264f0bc92d3d93d611fca
--- /dev/null
+++ b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
@@ -0,0 +1,81 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_
+#define CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/timer/elapsed_timer.h"
+#include "components/autofill/core/browser/ui/save_card_bubble_controller.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "content/public/browser/web_contents_user_data.h"
+
+namespace autofill {
+
+// Implementation of per-tab class to control the save credit card bubble and
+// Omnibox icon.
+//
+// TODO(bondd): Add text strings so different dialog contents can be shown
+// depending upon whether upstreaming is available.
+class SaveCardBubbleControllerImpl
+ : public SaveCardBubbleController,
+ public content::WebContentsObserver,
+ public content::WebContentsUserData<SaveCardBubbleControllerImpl> {
+ public:
+ // |save_card_callback| will be invoked if/when the Save button is pressed.
+ void SetCallback(const base::Closure& save_card_callback);
+
+ // SetCallback() must be called first.
+ void ShowBubble();
+
+ // Returns true if Omnibox save credit card icon should be visible.
+ bool IsIconVisible() const;
+
+ // Returns true if Omnibox save credit card should be shown in its "toggled
+ // on" state.
+ bool IsIconToggled() const;
+
+ // Returns nullptr if no bubble is currently shown.
+ SaveCardBubbleView* save_card_bubble_view() const;
+
+ // SaveCardBubbleController:
+ void OnSaveButton() override;
+ void OnCancelButton() override;
+ void OnBubbleClosed() override;
+
+ private:
+ friend class content::WebContentsUserData<SaveCardBubbleControllerImpl>;
+
+ explicit SaveCardBubbleControllerImpl(content::WebContents* web_contents);
+ ~SaveCardBubbleControllerImpl() override;
+
+ // Update the visibility and toggled state of the Omnibox save card icon.
+ void UpdateIcon();
+
+ // content::WebContentsObserver:
+ void DidNavigateMainFrame(
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) override;
+
+ content::WebContents* web_contents_;
+
+ // Will be nullptr if no bubble is currently shown.
+ SaveCardBubbleView* save_card_bubble_view_;
Evan Stade 2015/10/22 23:02:43 also note that it's a weak ref
bondd 2015/10/23 03:32:34 Done.
+
+ // Callback to run if user presses Save button in the bubble.
+ // If save_card_callback_.is_null() is true then no bubble is available to
+ // show and the icon is not visible.
+ base::Closure save_card_callback_;
+
+ // Used to measure the amount of time on a page; if it's less than some
+ // reasonable limit, then don't close the bubble upon navigation.
+ scoped_ptr<base::ElapsedTimer> timer_;
+
+ DISALLOW_COPY_AND_ASSIGN(SaveCardBubbleControllerImpl);
+};
+
+} // namespace autofill
+
+#endif // CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698