Create WebInbandTextTrack and WebInbandTextTrackClient

Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

Index: Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
index 717d27d003312427c6058ea740f4edb3440c57d1..7a240064d2f5038a73303c3979861fa93b43f1a1 100644
--- a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
+++ b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
@@ -6,6 +6,7 @@
 #include "WebMediaPlayerClientImpl.h"
 
 #include "HTMLMediaElement.h"
+#include "InbandTextTrackPrivateImpl.h"
 #include "PlatformContextSkia.h"
 #include "TimeRanges.h"
 #include "WebAudioSourceProvider.h"
@@ -13,6 +14,7 @@
 #include "WebFrameClient.h"
 #include "WebFrameImpl.h"
 #include "WebHelperPluginImpl.h"
+#include "WebInbandTextTrack.h"
 #include "WebMediaPlayer.h"
 #include "WebMediaSourceImpl.h"
 #include "WebViewImpl.h"
@@ -296,6 +298,19 @@ void WebMediaPlayerClientImpl::setWebLayer(WebLayer* layer)
     }
 }
 
+void WebMediaPlayerClientImpl::addTextTrack(WebInbandTextTrack* text_track)

[abarth-chromium, 2013/04/30 18:36:16]

text_track -> textTrack (Blink uses camelCase variable names)

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+{
+    m_mediaPlayer->addTextTrack(
+      adoptRef(new InbandTextTrackPrivateImpl(text_track)));

[abarth-chromium, 2013/04/30 18:36:16]

There is no 80 col limit.  You can just put these on the same line.

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+}
+
+void WebMediaPlayerClientImpl::removeTextTrack(WebInbandTextTrack* text_track)
+{
+    WebInbandTextTrackClient* const client = text_track->client();
+    InbandTextTrackPrivateImpl* const text_track_private = static_cast<InbandTextTrackPrivateImpl*>(client);

[acolwell GONE FROM CHROMIUM, 2013/04/30 18:00:46]

nit: Add a comment here similar to the one in
HTMLMediaElement::mediaPlayerDidRemoveTrack() stating why this case is safe.

Also the two temporaries variables here don't really buy you anything here. Just
do the cast and text_track->client() call inside the removeTextTrack() call.

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+    m_mediaPlayer->removeTextTrack(text_track_private);

[abarth-chromium, 2013/04/30 18:36:16]

camelCase pls

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+}
+
 // MediaPlayerPrivateInterface -------------------------------------------------
 
 void WebMediaPlayerClientImpl::load(const String& url)