Create WebInbandTextTrack and WebInbandTextTrackClient

Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "WebMediaPlayerClientImpl.h"
 
 #include "HTMLMediaElement.h"
+#include "InbandTextTrackPrivateImpl.h"
 #include "PlatformContextSkia.h"
 #include "TimeRanges.h"
 #include "WebAudioSourceProvider.h"
 #include "WebDocument.h"
 #include "WebFrameClient.h"
 #include "WebFrameImpl.h"
 #include "WebHelperPluginImpl.h"
+#include "WebInbandTextTrack.h"
 #include "WebMediaPlayer.h"
 #include "WebMediaSourceImpl.h"
 #include "WebViewImpl.h"
 #include "core/page/Frame.h"
 #include "core/platform/KURL.h"
 #include "core/platform/NotImplemented.h"
 #include "core/platform/audio/AudioBus.h"
 #include "core/platform/audio/AudioSourceProvider.h"
 #include "core/platform/audio/AudioSourceProviderClient.h"
 #include "core/platform/chromium/support/GraphicsContext3DPrivate.h"
@@ skipping 263 matching lines @@
 
     if (m_videoLayer)
         GraphicsLayerChromium::unregisterContentsLayer(m_videoLayer);
     m_videoLayer = layer;
     if (m_videoLayer) {
         m_videoLayer->setOpaque(m_opaque);
         GraphicsLayerChromium::registerContentsLayer(m_videoLayer);
     }
 }
 
+void WebMediaPlayerClientImpl::addTextTrack(WebInbandTextTrack* text_track)

[abarth-chromium, 2013/04/30 18:36:16]

text_track -> textTrack (Blink uses camelCase variable names)

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+{
+    m_mediaPlayer->addTextTrack(
+      adoptRef(new InbandTextTrackPrivateImpl(text_track)));

[abarth-chromium, 2013/04/30 18:36:16]

There is no 80 col limit.  You can just put these on the same line.

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+}
+
+void WebMediaPlayerClientImpl::removeTextTrack(WebInbandTextTrack* text_track)
+{
+    WebInbandTextTrackClient* const client = text_track->client();
+    InbandTextTrackPrivateImpl* const text_track_private = static_cast<InbandTextTrackPrivateImpl*>(client);

[acolwell GONE FROM CHROMIUM, 2013/04/30 18:00:46]

nit: Add a comment here similar to the one in
HTMLMediaElement::mediaPlayerDidRemoveTrack() stating why this case is safe.

Also the two temporaries variables here don't really buy you anything here. Just
do the cast and text_track->client() call inside the removeTextTrack() call.

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+    m_mediaPlayer->removeTextTrack(text_track_private);

[abarth-chromium, 2013/04/30 18:36:16]

camelCase pls

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+}
+
 // MediaPlayerPrivateInterface -------------------------------------------------
 
 void WebMediaPlayerClientImpl::load(const String& url)
 {
     m_url = KURL(ParsedURLString, url);
     m_mediaSource = 0;
     loadRequested();
 }
 
 void WebMediaPlayerClientImpl::load(const String& url, PassRefPtr<WebCore::MediaSource> mediaSource)
@@ skipping 569 matching lines @@
 
 void WebMediaPlayerClientImpl::AudioClientImpl::setFormat(size_t numberOfChannels, float sampleRate)
 {
     if (m_client)
         m_client->setFormat(numberOfChannels, sampleRate);
 }
 
 #endif
 
 } // namespace WebKit