Create WebInbandTextTrack and WebInbandTextTrackClient

Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

Index: Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
index d61c55a07acb61dca51c353be7603374ee1ce91d..293a22f194f42e821517128396b88e2f668932db 100644
--- a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
+++ b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
@@ -15,6 +15,7 @@
 #include "GraphicsContext3DPrivate.h"
 #include "GraphicsLayerChromium.h"
 #include "HTMLMediaElement.h"
+#include "InbandTextTrackPrivateImpl.h"
 #include "IntSize.h"
 #include "KURL.h"
 #include "MediaPlayer.h"
@@ -298,6 +299,18 @@ void WebMediaPlayerClientImpl::setWebLayer(WebLayer* layer)
     }
 }
 
+void WebMediaPlayerClientImpl::addTextTrack(WebInbandTextTrack* text_track)
+{
+    m_mediaPlayer->addTextTrack(
+      adoptRef(new InbandTextTrackPrivateImpl(text_track)));
+}
+
+void WebMediaPlayerClientImpl::removeTextTrack(WebInbandTextTrack* text_track)
+{
+    m_mediaPlayer->removeTextTrack(
+      adoptRef(new InbandTextTrackPrivateImpl(text_track)));

[acolwell GONE FROM CHROMIUM, 2013/04/23 06:34:18]

This doesn't look right to me. Are you sure this works? It looks like the client
pointer won't be set properly on this new InbandTextTrackPrivateImpl() instance
so the code in HTMLMediaElement::mediaPlayerDidRemoveTrack() won't behave
properly. 
It seems like you may need some way to map the WebInbandTextTrack instance to
the InbandTextTrackPrivateImpl instance created in addTextTrack(). You could
probably use the a casting trick like
HTMLMediaElement::mediaPlayerDidRemoveTrack() does since you know the
WebInbandTextTrackClient passed to a WebInbandTextTrack is a
InbandTextTrackPrivateImpl.

[Matthew Heaney (Chromium), 2013/04/24 04:32:18]

For now I just added a // TODO.  I'll take a look at what you're describing
here.

[Matthew Heaney (Chromium), 2013/04/27 06:06:28]

Done.

+}
+
 // MediaPlayerPrivateInterface -------------------------------------------------
 
 void WebMediaPlayerClientImpl::load(const String& url)