Create WebInbandTextTrack and WebInbandTextTrackClient

Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "WebMediaPlayerClientImpl.h"
 
 #if ENABLE(VIDEO)
 
 #include "AudioBus.h"
 #include "AudioSourceProvider.h"
 #include "AudioSourceProviderClient.h"
 #include "Frame.h"
 #include "GraphicsContext.h"
 #include "GraphicsContext3DPrivate.h"
 #include "GraphicsLayerChromium.h"
 #include "HTMLMediaElement.h"
+#include "InbandTextTrackPrivateImpl.h"
 #include "IntSize.h"
 #include "KURL.h"
 #include "MediaPlayer.h"
 #include "NotImplemented.h"
 #include "PlatformContextSkia.h"
 #include "RenderLayerCompositor.h"
 #include "RenderView.h"
 #include "TimeRanges.h"
 #include "WebAudioSourceProvider.h"
 #include "WebDocument.h"
@@ skipping 263 matching lines @@
 
     if (m_videoLayer)
         GraphicsLayerChromium::unregisterContentsLayer(m_videoLayer);
     m_videoLayer = layer;
     if (m_videoLayer) {
         m_videoLayer->setOpaque(m_opaque);
         GraphicsLayerChromium::registerContentsLayer(m_videoLayer);
     }
 }
 
+void WebMediaPlayerClientImpl::addTextTrack(WebInbandTextTrack* text_track)
+{
+    m_mediaPlayer->addTextTrack(
+      adoptRef(new InbandTextTrackPrivateImpl(text_track)));
+}
+
+void WebMediaPlayerClientImpl::removeTextTrack(WebInbandTextTrack* text_track)
+{
+    m_mediaPlayer->removeTextTrack(
+      adoptRef(new InbandTextTrackPrivateImpl(text_track)));

[acolwell GONE FROM CHROMIUM, 2013/04/23 06:34:18]

This doesn't look right to me. Are you sure this works? It looks like the client
pointer won't be set properly on this new InbandTextTrackPrivateImpl() instance
so the code in HTMLMediaElement::mediaPlayerDidRemoveTrack() won't behave
properly. 
It seems like you may need some way to map the WebInbandTextTrack instance to
the InbandTextTrackPrivateImpl instance created in addTextTrack(). You could
probably use the a casting trick like
HTMLMediaElement::mediaPlayerDidRemoveTrack() does since you know the
WebInbandTextTrackClient passed to a WebInbandTextTrack is a
InbandTextTrackPrivateImpl.

[Matthew Heaney (Chromium), 2013/04/24 04:32:18]

For now I just added a // TODO.  I'll take a look at what you're describing
here.

[Matthew Heaney (Chromium), 2013/04/27 06:06:28]

Done.

+}
+
 // MediaPlayerPrivateInterface -------------------------------------------------
 
 void WebMediaPlayerClientImpl::load(const String& url)
 {
     m_url = KURL(ParsedURLString, url);
     m_mediaSource = 0;
     loadRequested();
 }
 
 void WebMediaPlayerClientImpl::load(const String& url, PassRefPtr<WebCore::MediaSource> mediaSource)
@@ skipping 571 matching lines @@
 {
     if (m_client)
         m_client->setFormat(numberOfChannels, sampleRate);
 }
 
 #endif
 
 } // namespace WebKit
 
 #endif  // ENABLE(VIDEO)