PRESUBMIT.py - Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 4760bc18eebc5a4eaeddb50e9265b0f7c16ae523..23ebd5759b5f5f5de105e2f425d123521e374c48 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -42,7 +42,7 @@ def _CommonChecks(input_api, output_api):

results = []

results.extend(input_api.canned_checks.PanProjectChecks(

input_api, output_api, excluded_paths=_EXCLUDED_PATHS,

- maxlen=250, license_header=license_header))

+ license_header=license_header))

acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 Why is this needed? It should probably be in a sep

Matthew Heaney (Chromium) 2013/04/18 23:15:42 I had a stale depot_tools. Fixed.

results.extend(_CheckForVersionControlConflicts(input_api, output_api))

results.extend(_CheckPatchFiles(input_api, output_api))

results.extend(_CheckTestExpectations(input_api, output_api))

« no previous file with comments | « no previous file | Source/WebCore/html/track/InbandTextTrack.cpp » ('j') | Source/WebCore/html/track/InbandTextTrack.cpp » ('J')