Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Blink. | 5 """Top-level presubmit script for Blink. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 24 matching lines...) Expand all Loading... | |
| 35 | 35 |
| 36 | 36 |
| 37 def _CommonChecks(input_api, output_api): | 37 def _CommonChecks(input_api, output_api): |
| 38 """Checks common to both upload and commit.""" | 38 """Checks common to both upload and commit.""" |
| 39 # We should figure out what license checks we actually want to use. | 39 # We should figure out what license checks we actually want to use. |
| 40 license_header = r'.*' | 40 license_header = r'.*' |
| 41 | 41 |
| 42 results = [] | 42 results = [] |
| 43 results.extend(input_api.canned_checks.PanProjectChecks( | 43 results.extend(input_api.canned_checks.PanProjectChecks( |
| 44 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, | 44 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, |
| 45 maxlen=250, license_header=license_header)) | 45 license_header=license_header)) |
|
acolwell GONE FROM CHROMIUM
2013/04/17 00:13:56
Why is this needed? It should probably be in a sep
Matthew Heaney (Chromium)
2013/04/18 23:15:42
I had a stale depot_tools. Fixed.
| |
| 46 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) | 46 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) |
| 47 results.extend(_CheckPatchFiles(input_api, output_api)) | 47 results.extend(_CheckPatchFiles(input_api, output_api)) |
| 48 results.extend(_CheckTestExpectations(input_api, output_api)) | 48 results.extend(_CheckTestExpectations(input_api, output_api)) |
| 49 return results | 49 return results |
| 50 | 50 |
| 51 | 51 |
| 52 def _CheckSubversionConfig(input_api, output_api): | 52 def _CheckSubversionConfig(input_api, output_api): |
| 53 """Verifies the subversion config file is correctly setup. | 53 """Verifies the subversion config file is correctly setup. |
| 54 | 54 |
| 55 Checks that autoprops are enabled, returns an error otherwise. | 55 Checks that autoprops are enabled, returns an error otherwise. |
| (...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 132 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 132 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 133 input_api, output_api, | 133 input_api, output_api, |
| 134 json_url='http://blink-status.appspot.com/current?format=json')) | 134 json_url='http://blink-status.appspot.com/current?format=json')) |
| 135 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 135 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 136 input_api, output_api)) | 136 input_api, output_api)) |
| 137 results.extend(_CheckSubversionConfig(input_api, output_api)) | 137 results.extend(_CheckSubversionConfig(input_api, output_api)) |
| 138 return results | 138 return results |
| 139 | 139 |
| 140 def GetPreferredTrySlaves(project, change): | 140 def GetPreferredTrySlaves(project, change): |
| 141 return ['linux_layout_rel', 'mac_layout_rel', 'win_layout_rel'] | 141 return ['linux_layout_rel', 'mac_layout_rel', 'win_layout_rel'] |
| OLD | NEW |