Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h
diff --git a/Source/WebKit/chromium/src/SourceBufferPrivateImpl.h b/Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h
similarity index 66%
copy from Source/WebKit/chromium/src/SourceBufferPrivateImpl.h
copy to Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h
index 5546ac30701ace4299f7149ac55876ed5e754c47..59c9af712236467c379b66138378d54ef501d072 100644
--- a/Source/WebKit/chromium/src/SourceBufferPrivateImpl.h
+++ b/Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h
@@ -28,34 +28,35 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef SourceBufferPrivateImpl_h
-#define SourceBufferPrivateImpl_h
+#ifndef WebInbandTextTrackClientImpl_h
+#define WebInbandTextTrackClientImpl_h
-#include "SourceBufferPrivate.h"
-#include <wtf/OwnPtr.h>
-#include <wtf/PassOwnPtr.h>
+#include "WebInbandTextTrackClient.h"
+
+namespace WebCore {
+class InbandTextTrackPrivateClient;
+}
namespace WebKit {
-class WebSourceBuffer;
+class WebInbandTextTrackClientImpl : public WebInbandTextTrackClient {
+ public:
+ explicit WebInbandTextTrackClientImpl(
+ WebCore::InbandTextTrackPrivateClient* client);
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: No need for line wrap or variable name here.
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
-class SourceBufferPrivateImpl : public WebCore::SourceBufferPrivate {
-public:
- explicit SourceBufferPrivateImpl(PassOwnPtr<WebSourceBuffer>);
- virtual ~SourceBufferPrivateImpl() { }
+ // TODO(matthewjheaney): need dtor here?
+ //virtual ~WebInbandTextTrackPrivateClientImpl() {}
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 Yes.
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
- // SourceBufferPrivate methods.
- virtual PassRefPtr<WebCore::TimeRanges> buffered();
- virtual void append(const unsigned char* data, unsigned length);
- virtual void abort();
- virtual bool setTimestampOffset(double);
- virtual void removedFromMediaSource();
+ virtual void addWebVTTCue(double start,
+ double end,
+ const WebString& id,
+ const WebString& content,
+ const WebString& settings);
-private:
- OwnPtr<WebSourceBuffer> m_sourceBuffer;
+ private:
+ WebCore::InbandTextTrackPrivateClient* client_;
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: s/client_/m_client/
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
};
+} // namespace WebKit
-}
-
-#endif
+#endif // WebInbandTextTrackClientImpl_h

Powered by Google App Engine
This is Rietveld 408576698