Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp b/Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..c80c3aa6e2d30fd588890d72149a5ee762c28dbc
--- /dev/null
+++ b/Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp
@@ -0,0 +1,25 @@
+#include <wtf/ExportMacros.h>
+#include <wtf/text/WTFString.h>
+#include "InbandTextTrackPrivateClient.h"
+#include "WebInbandTextTrackClientImpl.h"
+#define WEBKIT_IMPLEMENTATION 1
+#include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
+
+namespace WebKit {
+
+WebInbandTextTrackClientImpl::WebInbandTextTrackClientImpl(
+ WebCore::InbandTextTrackPrivateClient* client)
+ : client_(client) {
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: { on its own line and add ASSERT(client);
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
+}
+
+void WebInbandTextTrackClientImpl::addWebVTTCue(
+ double start,
+ double end,
+ const WebString& id,
+ const WebString& content,
+ const WebString& settings) {
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: { on its own line.
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
+ // TODO(matthewjheaney): resolve value of first param
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 looks like a pointer to the InbandTextTrackPrivate
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
+ client_->addWebVTTCue(NULL, start, end, id, content, settings);
+}
+
+} // namespace WebKit

Powered by Google App Engine
This is Rietveld 408576698